Merge pull request #412 from seanmil/MODULES-1771

(MODULES-1771) Don't modify input to is_domain_name()
jguiditta · Feb 19, 2015 · fcd2f53 · fcd2f53
2 parents ad57272 + 1321d58
commit fcd2f53
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/puppet/parser/functions/is_domain_name.rb b/lib/puppet/parser/functions/is_domain_name.rb
@@ -13,7 +13,7 @@ module Puppet::Parser::Functions
         "given #{arguments.size} for 1")
     end
 
-    domain = arguments[0]
+    domain = arguments[0].dup
 
     # Limits (rfc1035, 3.1)
     domain_max_length=255

diff --git a/spec/functions/is_domain_name_spec.rb b/spec/functions/is_domain_name_spec.rb
@@ -61,4 +61,11 @@
     result = scope.function_is_domain_name(["not valid"])
     expect(result).to(be_falsey)
   end
+
+  # Values obtained from Facter values will be frozen strings
+  # in newer versions of Facter:
+  it "should not throw an exception if passed a frozen string" do
+    result = scope.function_is_domain_name(["my.domain.name".freeze])
+    expect(result).to(be_truthy)
+  end
 end