-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button sizes, could be responsive #1572
Button sizes, could be responsive #1572
Comments
I like the idea, but disagree with the approach of using media breakpoints to determine size, more so I'm not convinced hard coding in pixels is the best way to go either. Just my $0.02. Perhaps consider expanding similar to how I have done for #1535, which adds size modifier classes so that the developer has more choice over the styling. Again, just my thoughts, I'm still waiting for merge / validation that this is what @jgthms would like going forward. |
Hello, I would like to work on this issue. I agree with @raygervais , using pixels is not the best way, so I would like to try his idea with size modifiers. |
@antoniobrandao, just want to confirm we are on the same page: Are you describing functionality not found in the size classes listed here? https://bulma.io/documentation/elements/button/#sizes Simply curious, having worked with @svitlana-galianova to investigate how this would be best implemented / extended, we saw that a lot of the ground work was already in place, thus referencing back to the documentation. |
Hi, thanks for the quick replies. Please disregard my hacky example, it was by no means a suggestion. I am familiar with that part of the documentation, included the example code in the original comment. My problem is, they are fixed sizes. I do love the idea of having these size classes, they make sense and are very helpful. It just feels to me intuitive that they could become responsive somehow. This would also affect border-radius, font-size, and icon sizeIn my current project, a responsive website, I had to customise font-size, border-radius, icon size for each button size at each breakpoint 😞 Personally I would be very happy if there was a simple class that we could add to these buttons, to make them responsive, according to predefined defaults. For example, imagine just adding a class "is-responsive" to a "is-large" button:
Would make the button change in size according to Bulma defaults, while remaining "Large" in proportion:
So the "is-large" class (and the others) would make sense in every Bulma breakpoint, not just in the default size. Thanks again |
Makes sense what you are saying @antoniobrandao, I'll work with @svitlana-galianova after 2018 begins to implement to the spec you described above. It makes sense now with that added description. I suppose I'll reference how my own PR was done (ratio wise, styling wise) for the added is-*, which follows suit to the suggested |
I ran into a similar issue. My solution was to use buttons inside columns while also adding the |
@Madgame3 I suppose that takes care of the width, but not the text size? |
I’ll have to play around with it a bit but try adding a text modifier class |
@raygervais @svitlana-galianova any news on this? |
still waiting for updates on responsive button sizes |
I am surprised that Bulma lacks something so simple. |
i ran into the same problem, also other people on stackoverflow (https://stackoverflow.com/questions/53145045/bulma-input-button-size-on-tablet) seems to have the same need, but i'm unable to find an out-of-the-box solution |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I hate having to spam all subscribers with another comment, but this is still an unresolved issue that affects many people - so I suppose it shouldn't be closed yet? |
As far as I know this is still an issue that need to be addressed with an out-of-the-box solution |
actually, just stumbled upon this, and |
Nice one @bkarlson, just stumbled onto this too. Should probably make it's way into the docs... |
Sadly is-large-desktop or is-small-mobile doesn't work. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is feature request. Don't dare to close Stale bot. |
+1 |
2 similar comments
+1 |
+1 |
Using |
My team suggested we use it. I frankly am over it. The support just sucks, get back to bootstrap or tailwind, maybe even material ui but no bulma. |
That’s why my team is using Tailwind now.
Em ter., 23 de nov. de 2021 às 10:06, Faraz Nisar ***@***.***>
escreveu:
… I don't know you all but bulma seems dead in the water if it takes ~4
years for something as basic as this to materialise. In my use case it's
not only about buttons but also inputs should have a responsive pattern
because on mobile the inputs are a little too big -_-
My team suggested we use it. I frankly am over it. The support just sucks,
get back to bootstrap or tailwind, maybe even material ui but no bulma.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1572 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEET4IS3XBY3RHXG6LI4KQLUNOGVHANCNFSM4EJ4OFBA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
+1.... |
+1 |
These sizes are great, but useless if we need them to be responsive. Would be great if there was a Bullma-way to make them responsive. Right now I did it myself, but it feels hacky.
Docs:
Hacky code: (not a suggestion)
The text was updated successfully, but these errors were encountered: