Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized morsecode symbols array and updated the MorseClient::writ… #96

Merged
merged 2 commits into from
Dec 23, 2019

Conversation

IU5HKU
Copy link
Contributor

@IU5HKU IU5HKU commented Dec 22, 2019

The idea was taken from the CubeSat way of doing morsecode, we gained 510bytes and extended the morsecode to the whole ascii table.

…e(uint8_t b) method

The whole idea was taken from the CubeSat way of doing morsecode,
@jgromes
Copy link
Owner

jgromes commented Dec 23, 2019

Thanks, I will push some formatting fixes to this branch if that's OK.

I did notice there's a Morse codes in the array for underscore, that doesn't seem to be a part of the ITU standard (https://www.itu.int/dms_pubrec/itu-r/rec/m/R-REC-M.1677-1-200910-I!!PDF-E.pdf), so I'll remove that.

Also, there are sone ITU Morse codes that do not have direct ASCII equivalent, like the starting signal or end of work. I think I'll append those at the end of the lookup table.

@IU5HKU
Copy link
Contributor Author

IU5HKU commented Dec 23, 2019 via email

@jgromes jgromes merged commit ba3bfde into jgromes:master Dec 23, 2019
@jgromes
Copy link
Owner

jgromes commented Dec 23, 2019

Tested and working on Arduino Uno + SX1278, decoded using fldigi.

Merged, thanks - and Merry Christmas!

@IU5HKU
Copy link
Contributor Author

IU5HKU commented Dec 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants