Fix stringop-truncation warning in AX25 callsign getter #958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringop-truncation warning was caught by GCC12 in the callsign getter, as it copies 6 characters instead of 7.
I see in in the header file : RADIOLIB_AX25_MAX_CALLSIGN_LEN + 1 I guess +1 is for the null termination.
So I added +1 to the copy in the getter as well, as i guess it was the intent to terminate the resulting char array as well.
Note that I don't use this feature of the library, (-> I havent tested it) nor I know if this is the correct way to fix.