Enabling ACK support for LoRaWAN frames.

[amalinda]

To the best of my knowledge, there isn't yet support to send frames with a request for ACK from the network server. This pull request makes an effort to enable an ACK request per frame by calling node.uplink(strUp, 10, true); from user space. This does not break existing functionality. I have tested this using the SX1262 radio and the Actility Thingpark Network server. The functionality seems to be working well.

Acknowledgement: I thank Jansen Christian Liando for his advice on how to enable this.

As always, I welcome feedback.

[StevenCellist]

Hi @jgamage91, before we do any double work... I am at almost 100% LoRaWAN v1.1 compatibility on a fork. Which includes bi-directional confirmed frames and MUCH more. You're welcome to do some testing so we can get it in here soon! Let me know :)

[amalinda]

Hi @jgamage91, before we do any double work... I am at almost 100% LoRaWAN v1.1 compatibility on a fork. Which includes bi-directional confirmed frames and MUCH more. You're welcome to do some testing so we can get it in here soon! Let me know :)

Oh I understand. Thats great to hear! I am happy to do some testing when you release it. So should I close this for now?
Or if you think this commit can add value to the library in the meantime, it would be lovely to see this accepted. Please advice.

[StevenCellist]

You can find the most recent version here:
https://github.com/StevenCellist/RadioLib/tree/bands_adr_mac
Some gotchas are listed here:
#821

If you have an SX126x board, it would be great if you can check out the code. One more gotcha that you'll need to watch out for: after joining, you'll need a delay(5000) in your main code as something there is not working very nicely yet.
If you have an SX127x, feel free to dig into the Rx windows and see if you can implement/copy the SX126x logic to get RxSingle with timeout working.. ;)

In case of problems, please enable a debug build and maybe post it as an issue on the fork with some sample output

[StevenCellist]

To follow this up, I implemented the SX127x on my fork/branch; tested but maybe not completely optimized yet. More testing coming up; getting close to a PR!

[jgromes]

@jgamage91 #867 was just merged, which includes ACK support among major revwork of the LoRaWAN implementation, so unfortunately I have to close this one now. We're still looking for people willing to test it before the next release though, so if you have some time for that, it would be very much appreciated.