Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api adapt esp core 3.0.0-alpha2 #860

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

lewisxhe
Copy link
Contributor

esp32 core has been updated from IDF V4.x.x to IDF V5.x.x, and RadioLIb uses the updated API. The function has been tested normally in 3.0.0-alpha2,
Please see the specific changes esp32-hal-ledc.h

@jgromes jgromes merged commit 039fa0f into jgromes:master Oct 28, 2023
29 checks passed
@jgromes
Copy link
Owner

jgromes commented Oct 28, 2023

All looks good, merged - thank you very much for the contribution!

@lyusupov
Copy link
Contributor

Guys, please, be aware that ESP_IDF_VERSION macro may not had been defined in Arduino Core 1.0.x series ( they use IDF < 4 )

@jgromes
Copy link
Owner

jgromes commented Oct 28, 2023

@lyusupov thanks for pointing that out - in that case, I will add a check for defined(ESP_IDF_VERSION) to catch those version (although 2.0.0 was released more than two years ago at this point).

@lyusupov
Copy link
Contributor

lyusupov commented Oct 28, 2023

I will add a check for defined(ESP_IDF_VERSION) to catch those version

Great !

although 2.0.0 was released more than two years ago at this point

There was a breaking change between 1.x and 2.x that they had replaced LL hardware layer from (ESP32 only) custom design onto an API that supports other SoCs (-S2, -S3, -C3, ...)

My opinion that 1.0.x is still the best (stability and performance wise) provided that an application needs no compatibility with more recent SoCs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants