modules: Don't read excess status data #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SX126x get status command returns a single status byte. The status byte is automatically read in the `Module::SPItransferStream()` function when we increment buffLen (see https://github.com/jgromes/RadioLib/blob/master/src/Module.cpp#L259). By setting numBytes we incorrectly end up reading 2 bytes. Instead set numBytes to zero so we only read the single status byte. Signed-off-by: Alistair Francis <[email protected]>
|
Well spotted, thanks! Setting the value to 0 actually makes sense, since the GetStatus command does not read any data after returning the status byte - unlike all other SX126x read commands. |
jgromes
added a commit
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SX126x get status command returns a single status byte. The status byte is automatically read in the
Module::SPItransferStream()function when we increment buffLen (seehttps://github.com/jgromes/RadioLib/blob/master/src/Module.cpp#L259).
By setting numBytes we incorrectly end up reading 2 bytes. Instead set numBytes to zero so we only read the single status byte.