Fix frequency issue on SX127x (#1368) #1369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SX127x requires that the LSB of the frequency register (Frf) be written in order to change the frequency, but the library was using a SPI writing function that checked for overwrites. If the LSB did not change, the new frequency would be written in successfully, but the frequency would stay at the module's default.
I changed it to use the lower level SPI writing function with no overwrite protection if there was no difference between the old and new contents for the LSB.
I have this commit working on my RFM96W board connected to an Arduino Nano Every, but I have not tested on any other platforms.