feat: Add tones support for the RPi Pico #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the CI for rpi-pico cannot build it. Which version of the SDK are you using? The CI checks out 1.5.1. |
|
This isn't a problem with the SDK actually. I forgot to commit my changes to the CMakeLists.txt file, my apologies. Let me do that quickly. |
|
@jgromes it should build properly now! |
jgromes
reviewed
Sep 27, 2024
jgromes
reviewed
Sep 27, 2024
|
Indeed, it does build now. I also left two minor comments, after those are addressed I think this can be merged. |
jgromes
approved these changes
Sep 27, 2024
|
All looks good now - merged, thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR adds overrides for the
tone()andnoTone()functions in the HAL for the RPi Pico. Tones are added based on bitbangs.This code was tested using the APRS_Position.ino example, modified for the Pico. Closes #1230