fix getRangingResult to properly account for signed numbers #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got numbers like this as I approached the slave (raw values before converting to meters): ``` Ranged: 8 Ranged: 6 Ranged: 3 Ranged: 3 Ranged: 5 Ranged: 5 Ranged: 5 Ranged: 6 Ranged: 1 Ranged: 1 Ranged: 800000 Ranged: 800003 Ranged: 800003 ``` This is because the ToF becomes smaller than the correction factor resulting in a negative number. This patch performs Sign Extension from 24bits to 32bits. This result in returning a negative meter value which makes more sense than an impossibly big one.
Jorropo
force-pushed
the
fix-signed-ranging-result
branch
from
893ba38 to
951bfc0
Compare
|
This could also happen if your ToF beacon time travel from the future. Altho I lack the hardware to test this properly. |
|
Looks good - merged, thank you for the contribution!
True, but I do not think we should we should be too worried about handling the presumably rare cases when the SX128x device doing the ranging is moving at superluminal speeds :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got numbers like this as I approached the slave (raw values before converting to meters):
This is because the ToF becomes smaller than the correction factor resulting in a negative number.
This patch performs Sign Extension from 24bits to 32bits. This result in returning a negative meter value which makes more sense than an impossibly big one.