[SX126x][SX128x][LR11x0] Don't report CRC mismatch if valid header received #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgromes
approved these changes
Sep 1, 2024
There was a problem hiding this comment.
Oh wow, you're fast :D as discussed in the linked issue, this solution works for me - @StevenCellist I don't think this should have any negative effects on the work you're doing at the LoRaWAN stack, but please confirm.
|
Nope, the LoRaWAN stack doesn't touch any Header IRQ, so good to go. |
|
Merged - @GUVWAF thank you for another contribution, it is greatly appreciated! |
|
Also thanks to you both for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1202.
Tested this based on #1190 already using an SX1262 radio. I was able to catch a packet where indeed the
HEADER_ERRIRQ was set, but alsoHEADER_VALIDand the payload CRC was OK, and the payload could be decrypted and parsed successfully.