Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SX1278.cpp to fix errataFix typo #1166

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

kb9nate
Copy link
Contributor

@kb9nate kb9nate commented Jul 18, 2024

The binary representations that were being written to register 0x31 were not setting the correct bit. In particular for the 500kHz bandwidth setting. Changed from 0b1000000 to 0b10000000

Pull request template

Thank you for taking the time to contribute to RadioLib development!
To keep this library organized, please follow these rules.

  1. Make sure the the code in your PR is tested and that you understand all its impacts.
  2. Ensure that all CI actions pass - PRs with failed CI will not be merged. CI actions run automatically for every commit pushed to the PR and test the following:
    a. Compilation for Arduino, ESP-IDF and on Raspberry Pi
    b. Runtime test on Raspberry Pi
    c. GitHub CodeQL check
    d. Cppcheck static code scan
  3. Follow code style guidelines in CONTRIBUTING.md
  4. Heads up - all PRs undergo review, during which you may be asked to correct or change some things. The purpose of this review is to keep regressions and bugs at the minimum, and to keep consistent coding style. Please take them as constructive criticism from people who may have a different point-of-view than you do.

After addressing/accepting the points above, delete the contents of this template and replace it with text explaining what is the goal of your PR, why you want to add it to the upstream and what are the foreseen impacts. Once again, thank you for taking the time to contribute!

The binary representations that were being written to register 0x31 were not setting the correct bit. In particular for the 500kHz bandwidth setting. Changed from 0b1000000 to 0b10000000
@jgromes jgromes merged commit 111fb37 into jgromes:master Jul 18, 2024
30 checks passed
@jgromes
Copy link
Owner

jgromes commented Jul 18, 2024

Well spotted - thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants