protocol: LoRaWAN: Allow configuring scanGuard #1158
Conversation
|
Does it come with a honking great warning about the consequential impact on the battery life of the device when someone over enthusiastically sets it to something silly like 1000? |
|
@alistair23 Thank you for the contribution, I think it's a valid idea. Though as @HeadBoffin suggests, it would be good to have a warning in the Doxygen description, to make it clear that this is for advanced users only. It is important to realize that by exposing this, we essentially allow the users to break the LoRaWAN Rx delay if they set some unexpectedly large value - for example, larger than the Rx delay itself, I don't know how will it behave at that point. |
|
The value must be restricted to the interval [0,500). 500 means that the Rx2 window would open at the very moment the Rx1 window closes, higher than that means negative delay (which is handled but means not complying to LW). So either a very very big warning or a setter that returns ERR_UNKNOWN if out of range to urge users to visit an exorcist... ;) |
The current code uses scanGuard to increase the Rx window. Sometimes the default 10ms scanGuard isn't enough. So allow uses of LoRaWAN to set a larger scanGuard. Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
alistair/scan-guard
branch
from
331aeff to
5b9cad0
Compare
|
Fixed! |
|
@alistair23 thank you for the contribution, merged! |
The current code uses scanGuard to increase the Rx window. Sometimes the default 10ms scanGuard isn't enough. So allow uses of LoRaWAN to set a larger scanGuard.