-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/NonArduino/Tock: Support RISC-V and bump libtock-c #1082
Conversation
e2a13e2
to
db1f9ba
Compare
Signed-off-by: Alistair Francis <[email protected]>
4ca1c93
to
940486e
Compare
I took a look in the CI runs and it looks like it's missing pretty basic stuff, like stdio and stdint: https://github.com/jgromes/RadioLib/actions/runs/8907994652/job/24462852153#step:5:8662 To me that makes it look like the environment is not set up correctly. So I'm not sure this should be merged before that gets resovled. Disabling RISC-V build in CI is a rather strange choice considering that this PR adds RISC-V support. |
What is happening is that the RadioLib cmake build environment in the CI isn't setup correctly for RISC-V, hence the missing stdio and stdint. I can't reproduce the failures locally in Arch, as Arch has better RISC-V packages. libtock-c also builds fine as it builds it's own standard libraries. The problem is that I can't easily get the Make information into CMake to get it to build successfully in the CI. I can use RadioLib as a library with libtock-c (with a not yet submitted patch) to build a RISC-V application and I can build this PR successfully locally for RISC-V. The CI happily builds libtock-c for RISC-V as well. The stdio and stdint headers are provided as well as the libraries, so there is just something slightly wrong in the CMake setup that fails in the CI, but I'm a little stuck reproducing it. |
940486e
to
f7695f8
Compare
But you have control over that environment, the |
de5969a
to
adea485
Compare
Signed-off-by: Alistair Francis <[email protected]>
adea485
to
492dee2
Compare
That's a fair point. I managed to fix it! So now RISC-V is built in the CI. The script still provides an option to skip the RISC-V RadioLib build in case others have an issue. Also the |
Logging good, thank you very much!
Thanks, RadioLib should be using |
No description provided.