Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoRaWAN] Resolve warnings, fix bugs for fixed bands #1021

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Conversation

jgromes
Copy link
Owner

@jgromes jgromes commented Mar 18, 2024

Found when manually checking LoRaWAN builds for platforms that were previously disabled in CI. These were mostly unused variables, however, random selection of join DR was also unused, so maybe that was a mistake?

cc @StevenCellist

@StevenCellist
Copy link
Collaborator

Ah, the drJR is now incorrectly 'forgotten' indeed. That function was using internal MAC commands which was a mistake (it overwrote the active state with the default channels), but apparently I also removed the MAC command to configure the required join-datarate. Will look at a fix.

@jgromes
Copy link
Owner Author

jgromes commented Mar 18, 2024

@StevenCellist thanks! You should be able to push to this branch, so feel free to add the fix here.

@StevenCellist
Copy link
Collaborator

StevenCellist commented Mar 18, 2024

Turns out that there was some more stuff to do: there was a bug in processing the CFList (for fixed bands) that caused the Tx power to drop by 14dBm upon a join, and not all scenarios w.r.t. selecting an initial datarate were handled. Changes tested on EU868/ABP and US915/OTAA.

@StevenCellist StevenCellist changed the title [LoRaWAN] Resolve warnings [LoRaWAN] Resolve warnings, fix bugs for fixed bands Mar 18, 2024
@StevenCellist
Copy link
Collaborator

Hold on a minute and I got one small thing as well :)

@StevenCellist
Copy link
Collaborator

Good to go now from my perspective

@jgromes jgromes merged commit cfc4259 into master Mar 18, 2024
30 checks passed
@jgromes
Copy link
Owner Author

jgromes commented Mar 18, 2024

Perfect, thanks for the help!

@StevenCellist StevenCellist deleted the lorawan-warnigns branch April 27, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants