-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoRaWAN] Resolve warnings, fix bugs for fixed bands #1021
Conversation
Ah, the |
@StevenCellist thanks! You should be able to push to this branch, so feel free to add the fix here. |
Turns out that there was some more stuff to do: there was a bug in processing the CFList (for fixed bands) that caused the Tx power to drop by 14dBm upon a join, and not all scenarios w.r.t. selecting an initial datarate were handled. Changes tested on EU868/ABP and US915/OTAA. |
Hold on a minute and I got one small thing as well :) |
Good to go now from my perspective |
Perfect, thanks for the help! |
Found when manually checking LoRaWAN builds for platforms that were previously disabled in CI. These were mostly unused variables, however, random selection of join DR was also unused, so maybe that was a mistake?
cc @StevenCellist