-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SX127x corrupted packets pass CRC check #200
Labels
enhancement
New feature or request
resolved
Issue was resolved (e.g. bug fixed, or feature implemented)
Comments
+1 for that I have this problem from time to time. Also I tested suggesting check in readData and it actually fixes that. |
jgromes
added a commit
that referenced
this issue
Nov 19, 2020
Should be resolved by c127712 |
jgromes
added
the
resolved
Issue was resolved (e.g. bug fixed, or feature implemented)
label
Nov 19, 2020
This is great! Thank you for adding the fix. |
Awesome Thnx! |
very helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
resolved
Issue was resolved (e.g. bug fixed, or feature implemented)
As per the discussion with @amirna2 in #111 (comment)
CRC check in
SX127x::readData()
should take into account whether CRC is currently enabled or not, since in some cases, corrupted LoRa headers with CRC bit set to 0 still pass (somehow), which causes decoding to fail, probably because the module incorrectly configures the coding rate based on the corrupted information from packet header.The text was updated successfully, but these errors were encountered: