Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SX127x corrupted packets pass CRC check #200

Closed
jgromes opened this issue Nov 12, 2020 · 5 comments
Closed

SX127x corrupted packets pass CRC check #200

jgromes opened this issue Nov 12, 2020 · 5 comments
Labels
enhancement New feature or request resolved Issue was resolved (e.g. bug fixed, or feature implemented)

Comments

@jgromes
Copy link
Owner

jgromes commented Nov 12, 2020

As per the discussion with @amirna2 in #111 (comment)

CRC check in SX127x::readData() should take into account whether CRC is currently enabled or not, since in some cases, corrupted LoRa headers with CRC bit set to 0 still pass (somehow), which causes decoding to fail, probably because the module incorrectly configures the coding rate based on the corrupted information from packet header.
@jgromes jgromes added the enhancement New feature or request label Nov 12, 2020
@kiryam
Copy link

kiryam commented Nov 19, 2020

+1 for that I have this problem from time to time. Also I tested suggesting check in readData and it actually fixes that.

jgromes added a commit that referenced this issue Nov 19, 2020
@jgromes
[SX127x] Added check for LoRa header CRC mismatch (#200)
c127712
@jgromes
Copy link
Owner Author

jgromes commented Nov 19, 2020

Should be resolved by c127712

@jgromes jgromes closed this as completed Nov 19, 2020
@jgromes jgromes added the resolved Issue was resolved (e.g. bug fixed, or feature implemented) label Nov 19, 2020
@amirna2
Copy link

amirna2 commented Nov 19, 2020

This is great! Thank you for adding the fix.

@TimoWielink
Copy link

Awesome Thnx!

@knouse1344
Copy link

very helpful

@IoTThinks IoTThinks mentioned this issue Mar 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request resolved Issue was resolved (e.g. bug fixed, or feature implemented)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kiryam @knouse1344 @jgromes @amirna2 @TimoWielink