Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting ways to set payload length in implicit header mode with SX127X #1345

Closed
snowrodeo opened this issue Dec 11, 2024 · 3 comments
Closed
Labels
enhancement New feature or request resolved Issue was resolved (e.g. bug fixed, or feature implemented)

Comments

@snowrodeo
Copy link

To set an SX127x device to use implicit headers, you need to use
setImplicit(payloadLength)

However, when putting the device into receive mode, you need to also set the payload length or it will default to 0 and overwrite the previously set value

Request that setReceive use the value from setImplicit instead of requiring an arg

@jgromes
Copy link
Owner

jgromes commented Dec 14, 2024

This is indeed a bit of an oversight - I think we can handle this similarly to how startReceive behaves in exaplicit mode: If the length is set to 0, it will use the previously configured implicit length. Otherwise, the length will be overwritten. Will this match your use case?

@jgromes jgromes added the enhancement New feature or request label Dec 14, 2024
@snowrodeo
Copy link
Author

snowrodeo commented Dec 15, 2024 via email

@jgromes
Copy link
Owner

jgromes commented Dec 15, 2024

Implemented in the commit above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resolved Issue was resolved (e.g. bug fixed, or feature implemented)
Projects
None yet
Development

No branches or pull requests

2 participants