-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong register in setDataShapingOOK? #110
Comments
I think you might be consfusing modulation type and data shaping - those are different things. Modulation type is the modulation that should be used for the transmission - FSK, OOK or LoRa. This is indeed set in However, in FSK and OOK, you also have the option to specify output filter for the signal, either Gaussian with different bandwidth-time products (in FSK), or low pass with different cutoff frequencies (in OOK). Those are in the register named
You don't have to call |
The datasheet shows ModulationShaping (which specifies the gaussian filters for FSK and frequency cutoffs for OOK) set to bits 4-3 of the RegOpMode register though. Plus RegPaRamp uses bits 0-3, 4, and 7-5, so not sure why |
Ah, I was looking at the SX1278 datasheet and implementation - that one is correct. You're right, on SX1272 data shaping is in SX127X_REG_OP_MODE. |
Should be fixed now, thanks for reporting! |
Why does
setDataShapingOOK
(sx1272.cpp, line 312) use theSX127X_REG_PA_RAMP
register? Shouldn't it useSX127X_REG_OP_MODE
instead, since that's where data shaping is set for both FSK and OOK?Also could you please explain why you need to call this when enabling OOK? Why not stick with the default assignment (no shaping)?
Thanks!
The text was updated successfully, but these errors were encountered: