Issue #37 - Non-default Keystore Types #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 11, 2014 15:23
…ions provide a KeyStore. This lets apps load certificates from devices such as SmartCards that aren't accessible via URL and won't work with the existing certificate() methods.
…at looks for etc/config/twitter.properties so developers can easily provide API tokens required for unit tests to pass successfully. Added etc/config/twitter.properties to .gitgnore so developers don't accidentally commit their API keys to the repo. Properties plugin will ignore a missing file and behave the same as the previous build, failing tests that depend on twitter access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37
Modified the AuthConfig class so the certificate() method is overloaded with three different options:
certificate(String path, String pass)behaves as the original method, using the system default keystore typecertificate(String path, String pass, String type)reads the specified file as a user-provided keystore typecertificate(KeyStore store, String pass)uses the user-provided KeyStore; this method allows loading of keys from external devices like SmartCards where a URL may not be availableAlso, added support for loading Twitter API configuration from
etc/config/twitter.propertiesand supplied a template file detailing the various options. It wasn't clear without delving into the POM that tests were failing because I hadn't configured the Twitter settings. This externalizes them so developers don't accidentally commit auth tokens to the repo.