Fix intToOptimisationLevel dynamic bounds

jgotoh · Nov 4, 2024 · b69d1c2 · b69d1c2
1 parent 18ec0e6
commit b69d1c2
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/Cabal/src/Distribution/Simple/Compiler.hs b/Cabal/src/Distribution/Simple/Compiler.hs
@@ -326,14 +326,18 @@ flagToOptimisationLevel (Just s) = case reads s of
 
 intToOptimisationLevel :: Int -> OptimisationLevel
 intToOptimisationLevel i
-  | i >= fromEnum (minBound :: OptimisationLevel)
-      && i <= fromEnum (maxBound :: OptimisationLevel) =
-      toEnum i
+  | i >= minLevel && i <= maxLevel = toEnum i
   | otherwise =
       error $
         "Bad optimisation level: "
           ++ show i
-          ++ ". Valid values are 0..2"
+          ++ ". Valid values are "
+          ++ show minLevel
+          ++ ".."
+          ++ show maxLevel
+  where
+    minLevel = fromEnum (minBound :: OptimisationLevel)
+    maxLevel = i <= fromEnum (maxBound :: OptimisationLevel)
 
 -- ------------------------------------------------------------