main: fix check_output #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defer all packages to be installed at once and cleanup merge artifacts.
argparse.ArgumentParser.parse_known_args splits the arguments in two lists, the known arguments and the remaining arguments. This is how the function is described in the official documentation. The original code that introduced parse_known_args, however, consistently named the respective lists `args` and `unknown`. The latter is rather confusing to find as a variable name in code, hence the name changes. In addition to this, the comment that I removed was a bit misleading, as it claimed that parse_known_args is an 'internal' method. The contrary is true: it is a public, documented method in the standard library which was specifically added for the purpose of argument forwarding. The code now describes itself well, so the comment is not needed anymore.
|
Okay the check output is fixed! |
|
Looks sensible and builds on Python 2.7. Accepted, of course. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.