-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow --reference-location to affect HTML output #7461
Conversation
2d9d74b
to
9ee0449
Compare
EndOfBlock
and EndOfSection
in HTML writer
Current docs for this option:
: Specify whether footnotes (and references, if The proposal is to allow this to affect footnotes in the HTML writer as well. |
9ee0449
to
655bb70
Compare
@jgm I've updated the manual. Let me know if anything else is needed. |
This looks good to me. Question:
|
@jgm they would be outside the section block (right after the section). I do not know what makes more sense, but if you advise I'll change the behavior (if different from what's already implemented) and add the tests. |
I think either of these structures could make sense:
or
I'm not sure which is better. In any case this should be a tested case. |
This works similarly to the markdown writer, but with special care taken to skipping section divs with what regards to the block level. The change also takes care to not modify the output if `EndOfDocument` is used.
655bb70
to
5db0a59
Compare
@jgm I've added the test. |
Great. Can you explain why it is important to add the extra class e.g. Also, have you tested, at least informally, with epubs and HTML slide shows (revealjs)? |
@jgm My use case for those classes is that I want to style sidenotes (like in this article https://mazzo.li/posts/vectorized-atan2.html ) differently from footnotes (like in this article https://mazzo.li/posts/haskell-backprop-short.html ). I thought that class names would be the cleanest way to do that. I have not tested epub or revealjs. If you tell me how to test (e.g. "modify this file in this way and check XYZ") I'll follow up. |
Just use Slide shows: create a markdown file with a few sections and some footnotes, then |
Have you tried slides with |
I have, yes. For ebooks, it's at the end of the section, with the And this is with the slides -- it's in its own slide, much like if it were at the end of the document, but per-section: I can think of several things that could be configurable:
But I think going forward with this is still an improvement. |
Agreed, thanks! |
This works similarly to the markdown writer, but with special care
taken to skipping section divs with what regards to the block level.
The change also takes care to not modify the output if
EndOfDocument
is used.
I implemented this to implement side notes without JavaScript -- see https://mazzo.li/posts/value-speculation.html for an example.