Add failing split filter test cases. See #134.

jg-rp · Dec 13, 2023 · 14ffce9 · 14ffce9
1 parent c6af741
commit 14ffce9
Showing 1 changed file with 40 additions and 0 deletions.
diff --git a/liquid/golden/split_filter.py b/liquid/golden/split_filter.py
@@ -40,4 +40,44 @@
         template=r'{{ "Hello there" | split: nosuchthing | join: "#" }}',
         expect="H#e#l#l#o# #t#h#e#r#e",
     ),
+    Case(
+        description="empty string argument",
+        template=(
+            r'{% assign a = "abc" | split: "" %}'
+            r"{% for i in a %}#{{ forloop.index0 }}{{ i }}{% endfor %}"
+        ),
+        expect="#0a#1b#2c",
+    ),
+    Case(
+        description="argument does not appear in string",
+        template=(
+            r'{% assign a = "abc" | split: "," %}'
+            r"{% for i in a %}#{{ forloop.index0 }}{{ i }}{% endfor %}"
+        ),
+        expect="#0abc",
+    ),
+    Case(
+        description="empty string and empty argument",
+        template=(
+            r'{% assign a = "" | split: "" %}'
+            r"{% for i in a %}{{ forloop.index0 }}{{ i }}{% endfor %}"
+        ),
+        expect="",
+    ),
+    Case(
+        description="empty string and single char argument",
+        template=(
+            r'{% assign a = "" | split: "," %}'
+            r"{% for i in a %}{{ forloop.index0 }}{{ i }}{% endfor %}"
+        ),
+        expect="",
+    ),
+    Case(
+        description="left matches argument",
+        template=(
+            r'{% assign a = "," | split: "," %}'
+            r"{% for i in a %}{{ forloop.index0 }}{{ i }}{% endfor %}"
+        ),
+        expect="",
+    ),
 ]