Watch v2 #9

danielmkn · 2021-12-11T00:49:23Z

No description provided.

…k verify the license and create a dummy repo with enabled Xray indexing

- Add more tests. - Replace plurals with single form - resource, filter, assigned_policy per PTRENG-3122 and GH-4 - Remove old tests and filter wrapper

- Move license verification to provider.go - Add create builds func for testing - Add watch build tests

- renamed singular 'resource' to 'watch_resource' to avoid errors - added HCL samples -

…[email protected] istead of paultyng in GH Actions

- Added auto-generated documentation with examples - Removed unused function - Added validation and description for Provider URL and access token - MakeFile changes to match the file for Projects

Remove pointers form watches.go

… the ID to "" to indicate this

- Use TypeSet instead of TypeList to avoid sorting problem. Use *schema.Set instead of []interface{} for TypeSet - Re-generate documentation - Use pointers only where we can't avoid it (nil verification of non-primitives in structs) - Added omitempty for some keys - Replace t.Fatal with t.Error as a less brutal method to stop the test - Some improvements in tests

github-actions · 2021-12-11T00:49:38Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️

.github/workflows/release.yml

GNUmakefile

examples/resources/xray_license_policy/resource.tf

pkg/xray/resource_xray_license_policy.go

pkg/xray/resource_xray_security_policy.go

pkg/xray/resource_xray_watch.go

pkg/xray/resource_xray_watch_test.go

alexhung

Getting close.

A few more minor things to work on.

pkg/xray/watches.go

docs/resources/watch.md

pkg/xray/provider.go

pkg/xray/resource_xray_license_policy.go

pkg/xray/resource_xray_security_policy.go

pkg/xray/resource_xray_watch.go

pkg/xray/watches.go

sample.tf

chb0github

Lots of feedback. Please correct

…f the blocks will be singular - remove ARTIFACTORY_URL - add more verifications for schema elements - re-generate documentation

danielmkn · 2021-12-14T03:23:35Z

@chb0github @alexhung Not sure about all the nil comments. I need to have more understanding of how diags work. I took it from the Hashi corp example.

danielmkn · 2021-12-14T19:33:15Z

@alexhung please check and approve

danielmkn added 25 commits November 17, 2021 11:26

Xray watch, first working version

05f2a6f

Xray watch, broken version, universal unpack attempt

9e2dbd4

Xray watch, broken version, universal unpack attempt

59ebd7d

Xray watch, WIP

316393d

Xray watch, add test for all-repos and repository watch. Make preChec…

825372c

…k verify the license and create a dummy repo with enabled Xray indexing

Xray watch, go.sum

31289a4

Xray watch.

9824448

- Add more tests. - Replace plurals with single form - resource, filter, assigned_policy per PTRENG-3122 and GH-4 - Remove old tests and filter wrapper

Xray watch

379a496

- Move license verification to provider.go - Add create builds func for testing - Add watch build tests

Xray watch, ConfigureContextFunc

ff00951

Xray watch

95d4bcd

- renamed singular 'resource' to 'watch_resource' to avoid errors - added HCL samples -

Xray watch. Documentation updates.

86e7294

Xray watch. Documentation updates.

406db21

Xray watch. Add validations

6a2397e

Xray watch. Assign new issues to myself. Use hashicorp/ghaction-impor…

b2e7cbe

…[email protected] istead of paultyng in GH Actions

Xray watch. Fixing most of the assignments from the PR conversation

df29488

Xray watch. PR comments. resourceXrayWatchRead function refactoring.

c4f03ec

Xray watch. More PR comments resolved.

1952c33

- Added auto-generated documentation with examples - Removed unused function - Added validation and description for Provider URL and access token - MakeFile changes to match the file for Projects

Remove invalid license from the .tf file example

fa48093

Remove pointers form watches.go

Fixed indentation

ccae964

Formatting, move test functions to test file

e9196be

Add validation to the policy type

1643aca

LIst validation moved to validators.go

acf5b4d

Re-generate documentation, change resources names to more meaningful

b7e4c31

if the resource has been deleted outside of TF knowledge, then we set…

b73e88c

… the ID to "" to indicate this

danielmkn requested a review from alexhung December 11, 2021 00:49

alexhung reviewed Dec 13, 2021

View reviewed changes

alexhung requested changes Dec 13, 2021

View reviewed changes