-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse time in local tz #238
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look ok. Please add a test for the tz use case in https://github.com/jfrog/terraform-provider-xray/blob/main/pkg/xray/resource/resource_xray_ignore_rule_test.go
@alexhung not familiar enough with go to write a test case for this usecase. |
- resolves jfrog#237 - update docs
@ritzk Ok no problem. I'll add that once this is merged. |
Release timezone fix from GH-238
resolve #237
Test env ( on alpine)
Set tz to EST
What is tested
Actual results:
Without this tz is parsed in UTC regardless of local tz
Expected result
tz should parsed in local tz, or provide the option to specify time with tz ( 2024-11-01T13:00-04:00/ 2024-11-01T13:00Z/...)