Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'component' conflict validations #147

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

alexhung
Copy link
Member

@alexhung alexhung commented Nov 16, 2023

With 'build' and 'release_bundle'

Close #146

With 'build' and 'release_bundle'
@alexhung alexhung added the bug Something isn't working label Nov 16, 2023
@alexhung alexhung marked this pull request as ready for review November 16, 2023 18:56
@alexhung alexhung requested a review from danielmkn as a code owner November 16, 2023 18:56
CHANGELOG.md Outdated Show resolved Hide resolved
@alexhung alexhung requested a review from danielmkn November 16, 2023 19:12
@alexhung alexhung merged commit 51ff55b into master Nov 16, 2023
1 check passed
@alexhung alexhung deleted the GH-146-fix-ignore-rule-attribute-conflict branch November 16, 2023 19:18
Copy link
Collaborator

@mritunjaykumar mritunjaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xray_ignore_rule error out when build and component is specifiy
4 participants