Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TFC Workload Identity Tokens #30

Closed
davidcorrigan714 opened this issue Feb 23, 2024 · 3 comments · Fixed by #54
Closed

Support for TFC Workload Identity Tokens #30

davidcorrigan714 opened this issue Feb 23, 2024 · 3 comments · Fixed by #54
Assignees
Labels
enhancement Automatically generated release notes

Comments

@davidcorrigan714
Copy link

Describe the solution you'd like
The provider should support authentication to Artifactory using a TFC Workload Identity Token. Essentially you set some environment variables then TFC makes the token available to the provider during runtime. More details here.

Describe alternatives you've considered
Traditionally manually managed tokens are provided to the provider for authentication. These OIDC tokens remove the burden of managing those tokens and mitigate some risks associated with any accidental or malicious leaks of those tokens.

@davidcorrigan714 davidcorrigan714 added the enhancement Automatically generated release notes label Feb 23, 2024
@alexhung alexhung transferred this issue from jfrog/terraform-provider-artifactory Feb 23, 2024
@alexhung
Copy link
Member

@davidcorrigan714 Thanks for the suggestion. I've added this to our plan.

@davidcorrigan714
Copy link
Author

davidcorrigan714 commented Feb 23, 2024

Oh, one thing I've been pondering and haven't quite poked at yet, is how OIDC is supposed to work across multiple nodes. For example we essentially have a hub and spoke model with a main source node and a bunch of edge nodes, all configured with Terraform. Seems like the OIDC implementation doesn't work on edge nodes at all(?) So anything using OIDC will need to get a token from our main source node in order to then use it against the edge nodes so everything using it now needs 2 urls to operate, some sort of "token provider / authentication url" and then the URL for actually fetching which in our case is a single URL that let's Route53 return the closest edge node based on location.

@davidcorrigan714
Copy link
Author

I'm actually going to open an official support ticket on this cause it's a problem with the documented GitHub use case.

alexhung added a commit that referenced this issue Apr 12, 2024
…identity-token

Add support for TFC workload identity token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Automatically generated release notes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants