Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Artifactory version check for Access user API #940

Merged
merged 10 commits into from
Apr 25, 2024

Conversation

alexhung
Copy link
Member

@alexhung alexhung commented Apr 19, 2024

  • The bug where 'password' field is required for update even when no change is needed, is fixed in 7.84.3 on Cloud version. So the user resources can use the new Access API from this version onwards.
  • Alias artifactory_unmanaged_user to same code as artifactory_user. This remove the last SDKv2 code from user resources, and simplify maintenance.
  • Make internal_password_disabled field into pointer and only send to API if it is set with a value.
  • Do not send password in API request if internal_password_disabled is true

Relates to #931

The bug where 'password' field is required for update even when no change is needed, is fixed in 7.84.3. So the user resources can use the new Access API from this version onwards.
@alexhung alexhung added the bug Something isn't working label Apr 19, 2024
This remove the last SDKv2 code from user resources, and simplify maintenance.

Make internal_password_disabled field into pointer and only send to API if it is set with a value.

Do not send 'password' in API request if internal_password_disabled is true
Add test skipping for configuration resource tests when running against cloud version
@alexhung alexhung marked this pull request as ready for review April 22, 2024 20:51
@alexhung alexhung merged commit f1ff3bf into master Apr 25, 2024
3 checks passed
@alexhung alexhung deleted the bump-user-access-api-version-check branch April 25, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants