Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Platform Proxy is set, it can't be explicitly unset in replications #1088

Closed
5 tasks done
OliverOlg opened this issue Oct 1, 2024 · 1 comment · Fixed by #1095
Closed
5 tasks done

If Platform Proxy is set, it can't be explicitly unset in replications #1088

OliverOlg opened this issue Oct 1, 2024 · 1 comment · Fixed by #1095
Assignees
Labels
bug Something isn't working

Comments

@OliverOlg
Copy link

Describe the bug
If you have a platform Proxy configured leaving the proxy empty or '= null' in the local_repository_multi_replication will result in the Platform default proxy being set. It's not possible to have no proxy set in this scenario, since artifactory will default to setting the platform proxy.

resource "artifactory_local_repository_multi_replication" "repo-local" {
    repo_key = "repo-local"
    cron_exp = "0 0 12 * * ? *"
    enable_event_replication = true

    replication {
        enabled = true
        url = "https://remote.artifactory/artifactory/repo-local"
        username = user
        password = password
        sync_deletes = true
        sync_statistics = true
        sync_properties = true
        # proxy = null
    }
}

Requirements for and issue

  • A description of the bug
  • A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue). If this is not supplied, this issue will likely be closed without any effort expended.
  • Your version of artifactory (you can curl it at $host/artifactory/api/system/version
    7.84.20
  • Your version of terraform
    Terraform v1.5.7
  • Your version of terraform provider
    12.1.0, but this hasn't worked in 9.3.0 either

Expected behavior
Setting proxy = null should result in the replication having no proxy.

Additional context
Since the provider does not implement the disableProxy that is available since 7.41.7 in the replication json
, it's not possible to create a replication that explicitly does not use a proxy.

@OliverOlg OliverOlg added the bug Something isn't working label Oct 1, 2024
@alexhung
Copy link
Member

alexhung commented Oct 1, 2024

@OliverOlg Thanks for the report. I've added this to our plan. Most likely I'll add the attribute disable_proxy to support your request.

alexhung added a commit that referenced this issue Oct 14, 2024
…te-to-replication

Add 'disable_proxy' attribute to artifactory_local_repository_multi_replication to support not using proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants