-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the "fix action" for indirect dependencies #500
Merged
eyalk007
merged 5 commits into
jfrog:master
from
eyalk007:bug-fix/cancel-fix-for-indirect-deps
Nov 4, 2024
Merged
Removed the "fix action" for indirect dependencies #500
eyalk007
merged 5 commits into
jfrog:master
from
eyalk007:bug-fix/cancel-fix-for-indirect-deps
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalk007
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 31, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 31, 2024
NatiBeer
approved these changes
Oct 31, 2024
NatiBeer
approved these changes
Oct 31, 2024
eyalk007
added
the
safe to test
Approve running integration tests on a pull request
label
Nov 3, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Nov 3, 2024
eyalk007
force-pushed
the
bug-fix/cancel-fix-for-indirect-deps
branch
from
November 3, 2024 11:34
0f049b7
to
a0fa773
Compare
eyalk007
added
the
safe to test
Approve running integration tests on a pull request
label
Nov 4, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run format
for formatting the code before submitting the pull request.The fix dependency option is being offered on indirect dependencies. Obviously this is an impossible task for us, so i blocked the ability by adding the check to the existing if statement.