Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit - Control Pip install cmd with custom args #87

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jun 18, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

You can now add custom args when installing Pip project for Audit command. (Applicable only when using Frogbot)

@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jun 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@attiasas attiasas changed the title Add option to control Pip install cmd with custom args Audit - Control Pip install cmd with custom args Jun 18, 2024
Copy link
Contributor

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a PR that runs integrations test in Frogbot for it

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 23, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jun 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 24, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit 2fa0db4 into jfrog:dev Jun 24, 2024
9 checks passed
@attiasas attiasas deleted the pip_install_cmd branch June 24, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants