-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved tech detection when tech is provided by user #175
Merged
eranturgeman
merged 10 commits into
jfrog:dev
from
eranturgeman:force-tech-detection-if-provided-from-install-command
Sep 15, 2024
Merged
Improved tech detection when tech is provided by user #175
eranturgeman
merged 10 commits into
jfrog:dev
from
eranturgeman:force-tech-detection-if-provided-from-install-command
Sep 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n tech by descriptor and not just indicator in case the tech is provided by the user
eranturgeman
temporarily deployed
to
frogbot
September 11, 2024 13:18 — with
GitHub Actions
Inactive
…o force-tech-detection-if-provided-from-install-command
eranturgeman
temporarily deployed
to
frogbot
September 11, 2024 13:19 — with
GitHub Actions
Inactive
eranturgeman
added
improvement
Automatically generated release notes
safe to test
Approve running integration tests on a pull request
labels
Sep 11, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
Merged
4 tasks
…o force-tech-detection-if-provided-from-install-command
eranturgeman
temporarily deployed
to
frogbot
September 11, 2024 14:37 — with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
…o force-tech-detection-if-provided-from-install-command
eranturgeman
temporarily deployed
to
frogbot
September 15, 2024 06:42 — with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
attiasas
requested changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!, take a look at my comments.
eranturgeman
changed the title
Enable tech detection by 'install' command
Improved tech detection when tech is provided by user
Sep 15, 2024
…o force-tech-detection-if-provided-from-install-command
attiasas
approved these changes
Sep 15, 2024
eranturgeman
temporarily deployed
to
frogbot
September 15, 2024 17:51 — with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
…o force-tech-detection-if-provided-from-install-command
eranturgeman
temporarily deployed
to
frogbot
September 15, 2024 17:52 — with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.This PR addresses an issue with incorrect technology detection in Yarn projects, particularly when there are multiple sub-projects that only contain a Yarn descriptor without any specific Yarn indicators. In a multi-project (but not multi-module) Yarn environment, if the inner projects only include the package.json file without any of Yarn’s standard indicators (.yarnrc.yml, yarn.lock, .yarn, “yarnrc”), the auto-detection mechanism incorrectly identifies these as NPM projects.
Since package.json cannot be used as an indicator for both NPM and Yarn to avoid conflicts, I implemented the following logic:
If the user specifies a particular technology (via command flags or the install command [Frogbot]), we take that into account when verifying the technology. This allows us to verify the specified technology using both its descriptors and indicators and not just its indicators.
As a result, when a ‘yarn install’ command is provided for a project and a package.json file is present, we can confidently determine that Yarn is being used, not NPM.
Another test case needs to be added to TestGetTechInformationFromWorkingDir. This test case discovered an issue that is fixed this PR: #179
The test case will be added along with the fix.