Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build scan command output in table format #172

Merged
merged 5 commits into from
Sep 15, 2024
Merged

Fix build scan command output in table format #172

merged 5 commits into from
Sep 15, 2024

Conversation

dortam888
Copy link
Contributor

@dortam888 dortam888 commented Sep 10, 2024 •
edited by attiasas
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Fix build scan command to always have violation context as the build scan API is running on build watches and intend to return violations. Also dropped all build hasViolationContext functions.
Additionally, Dropped additional printing in the table format that made the command print the vulnerability table twice.

@dortam888
change build scan to always print violations context (as the api alwa…
8eb0196 
…ys runs on watches) the command will print violations alone at default and will append vulnerabilities with --vuln flag
@dortam888
changed the record to always have true violation context and dropped …
4aebc19 
…the function to change the violation context
@dortam888
make the code readable and fix the security job summary for build sca…
c70c8db 
…n to always have violations requested
@dortam888 dortam888 added the bug Something isn't working label Sep 10, 2024
@dortam888 dortam888 changed the title Fix build scan command that didn't print without flags. Fix build scan command output in table format Sep 10, 2024
@dortam888 dortam888 added the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@dortam888 dortam888 requested a review from attiasas September 11, 2024 07:12
@attiasas attiasas mentioned this pull request Sep 15, 2024
Open
attiasas
attiasas approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 15, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas merged commit 1bcec51 into jfrog:dev Sep 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dortam888 @attiasas