Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show findings in Sast #970

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Show findings in Sast #970

merged 2 commits into from
Sep 20, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Sep 20, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix bug not showing Sast findings from #927

image

@attiasas attiasas added the bug Something isn't working label Sep 20, 2023
@attiasas attiasas changed the base branch from master to dev September 20, 2023 11:58
@attiasas attiasas changed the title Show findings iac sast Show findings in Sast Sep 20, 2023
@attiasas attiasas requested a review from sverdlov93 September 20, 2023 12:01
@attiasas attiasas marked this pull request as ready for review September 20, 2023 12:01
@attiasas attiasas merged commit fd8b279 into jfrog:dev Sep 20, 2023
7 of 8 checks passed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @sverdlov93