Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self-signed certificate question in Config #1258

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Sep 4, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Every time a user interactively logs in to the JFrog platform, they are asked the following question:

Is the Artifactory reverse proxy configured to accept a client certificate?

This pull request removes that question.

  • For the jf c add command, users still can provide certificates using the --client-cert-key-path and --client-cert-path flags if necessary.
  • For the jf login command, self-signed certificates will not be supported at this time. Users should use the jf c add command instead.

@yahavi yahavi added the improvement Automatically generated release notes label Sep 4, 2024
@yahavi yahavi requested review from eyalbe4 and RobiNino September 4, 2024 07:44
@yahavi yahavi self-assigned this Sep 4, 2024
@yahavi yahavi changed the title Remove cert question in config add Remove self-signed certificate question in config add Sep 4, 2024
@yahavi yahavi changed the title Remove self-signed certificate question in config add Remove self-signed certificate question in Config Sep 4, 2024
@yahavi yahavi merged commit 7a9f46d into jfrog:dev Sep 9, 2024
6 of 7 checks passed
@yahavi yahavi deleted the rm-cert-question branch September 9, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants