Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Conda/Yum/Swift handlers for repository creation template #1106

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Add missing Conda/Yum/Swift handlers for repository creation template #1106

merged 4 commits into from
Jan 17, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Jan 14, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

following jfrog/jfrog-cli#2414

@sverdlov93
fix conda
e9c7a12 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 changed the base branch from master to dev January 14, 2024 14:05
@sverdlov93 sverdlov93 requested review from yahavi and eyalbe4 January 14, 2024 14:06
@sverdlov93 sverdlov93 changed the title Add missing Conda handler for federated repositories creation Add missing Conda/Yum handler for federated repositories creation Jan 14, 2024
@sverdlov93
fix conda
f82cd92 
Signed-off-by: Michael Sverdlov <[email protected]>
yahavi
yahavi approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sverdlov93 sverdlov93 changed the title Add missing Conda/Yum handler for federated repositories creation Add missing Conda/Yum handler for local/federated repositories creation Jan 16, 2024
@sverdlov93 sverdlov93 changed the title Add missing Conda/Yum handler for local/federated repositories creation Add missing Conda/Yum/Swift handler for repositories creation template Jan 17, 2024
@sverdlov93 sverdlov93 changed the title Add missing Conda/Yum/Swift handler for repositories creation template Add missing Conda/Yum/Swift handlers for repository creation template Jan 17, 2024
@sverdlov93
fix conda
ce0bf47 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 merged commit 117e8e5 into jfrog:dev Jan 17, 2024
7 of 8 checks passed
@sverdlov93 sverdlov93 mentioned this pull request Jan 17, 2024
Closed
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @yahavi