Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer - Improve time estimation algorithm #1043

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 23, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Introduce a new time estimation algorithm for the jf rt transfer-files command:
Divide the transferred bytes in the ongoing process by the remaining size.

The time estimation will only show up if these conditions are fulfilled:

  1. Five minutes have elapsed since the transfer started.
  2. A minimum of one file has been successfully transferred.
  3. The calculated speed is at least one byte per second.

@yahavi yahavi marked this pull request as ready for review November 23, 2023 12:02
@yahavi yahavi merged commit 2c2ac13 into jfrog:dev Nov 26, 2023
7 of 8 checks passed
@yahavi yahavi deleted the improve-time-estimation branch November 26, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants