-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function to get the latest commit #4
Conversation
20c453e
to
87256b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Please look at my inline comments.
Also - I wonder whether Commit ID
is the best naming. What do you think about Commit Hash
?
87256b0
to
9098d2f
Compare
@yahavi Would it make sense to not just return the commit hash but the full details (hash, author, comment) ? We could event return the N latest commits. |
Yes, of course. You can return a struct. We already return a struct in
We can, but do we need more than 1 commit? |
d4659b1
to
e6a2870
Compare
I thought about this too, but there are many differences between the providers and I wasn't sure what to return. We could return a struct (or slice of said struct) and add fields later if needed, but I'm not sure how froggit handles api versioning. @yahavi What do you think? |
@ttetzlaff take a look at the |
eeb6bd5
to
5a7912e
Compare
5a7912e
to
8e78c80
Compare
No description provided.