Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list pull request labels API #36

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Add list pull request labels API #36

merged 2 commits into from
Mar 23, 2022

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Mar 23, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used go fmt ./... for formatting the code before submitting the pull request.
  • This feature is included on all supported VCS providers - GitHub, Bitbucket cloud, Bitbucket server, and GitLab.
  • Add ListPullRequestLabels on the VscClient.
  • Add missing validateParametersNotBlank on UnlabelPullRequest in GitHub.
  • Refactor validate_required_params_test

@yahavi yahavi self-assigned this Mar 23, 2022
talarian1
talarian1 approved these changes Mar 23, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@yahavi yahavi merged commit f799732 into jfrog:master Mar 23, 2022
@yahavi yahavi deleted the get-pr-label branch March 23, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talarian1 talarian1 talarian1 approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees

@yahavi yahavi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @talarian1