Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support labels API #35

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Support labels API #35

merged 3 commits into from
Mar 22, 2022

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Mar 22, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used go fmt ./... for formatting the code before submitting the pull request.
  • This feature is included on all supported VCS providers - GitHub, Bitbucket cloud, Bitbucket server, and GitLab.

Add labels APIs for GitHub and GitLab.
Currently, labels in Bitbucket are not supported: https://jira.atlassian.com/browse/BSERV-10715

@yahavi yahavi self-assigned this Mar 22, 2022
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
return err
}

// GetLabel on GitHub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// GetLabel on GitHub
// GetLabel from GitHub

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all other places it is "on"

vcsclient/gitlab.go Show resolved Hide resolved
vcsclient/gitlab.go Show resolved Hide resolved
@yahavi yahavi merged commit 5fcbcb7 into jfrog:master Mar 22, 2022
@yahavi yahavi deleted the labels branch March 22, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants