Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitLab Update MR #119

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Sep 14, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used go fmt ./... for formatting the code before submitting the pull request.
  • This feature is included on all supported VCS providers - GitHub, Bitbucket cloud, Bitbucket server, GitLab and Azure Repos.
  • I added the relevant documentation for the new feature.

Bug description:

We used close/open for state_event object when updating GitLab Merge Request.
Which resolved in panic and errors from the api.


state_event string no New state (close/reopen).

Fix:

Update to valid states, update open -> reopen.

GitLab api docs: https://docs.gitlab.com/ee/api/merge_requests.html#update-mr

@github-actions
Copy link
Contributor


@EyalDelarea EyalDelarea merged commit 7371a84 into jfrog:master Sep 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants