Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get latest commit in gitlab returns empty reponse #9

Closed
ttetzlaff opened this issue Nov 3, 2021 · 0 comments · Fixed by #28
Closed

Get latest commit in gitlab returns empty reponse #9

ttetzlaff opened this issue Nov 3, 2021 · 0 comments · Fixed by #28
Labels
bug Something isn't working

Comments

@ttetzlaff
Copy link
Contributor

The GitLab client returns an empty response for the latest commit of an unknown branch instead of an error.

Other providers return a 404 error, so GitLab client should do the same.
@yahavi yahavi added the bug Something isn't working label Jan 11, 2022
ttetzlaff added a commit to ttetzlaff/froggit-go that referenced this issue Jan 19, 2022
@ttetzlaff
Fix get latest commit for gitlab returns empty
c447cd7 
fixes jfrog#9
@ttetzlaff ttetzlaff mentioned this issue Jan 19, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix get latest commit for gitlab returns empty ttetzlaff/froggit-go
2 participants
@yahavi @ttetzlaff