Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple no proxy hosts in Maven #801

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Aug 9, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

Fix jfrog/jfrog-cli#2638

The NO_PROXY pattern for specifying multiple hosts is a comma-separated list:
NO_PROXY=host1.jfrog.io,host2.jfrog.io
https://www.gnu.org/software/emacs/manual/html_node/url/Proxies.html

In Java, the system property http.nonProxyHosts uses a pipe-separated list for multiple hosts:
-Dhttp.nonProxyHosts=host1.jfrog.io|host2.jfrog.io
https://docs.oracle.com/javase/8/docs/technotes/guides/net/proxies.html

This pull request adjusts the http.nonProxyHosts value by replacing commas with pipes.

@yahavi yahavi added the bug Create a report to help us improve label Aug 9, 2024
@yahavi yahavi requested review from Or-Geva and RobiNino August 9, 2024 10:53
@yahavi yahavi self-assigned this Aug 9, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Aug 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Aug 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Aug 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Aug 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2024
@yahavi yahavi merged commit f36267b into jfrog:master Aug 9, 2024
95 of 125 checks passed
@yahavi yahavi deleted the multiple-no-proxy branch August 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Create a report to help us improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no support multiple NO_PROXY variable on maven
2 participants