Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nuget nuspec files UTF-16 encoding issue #226

Merged
merged 37 commits into from
Dec 27, 2023
Merged

Fix Nuget nuspec files UTF-16 encoding issue #226

merged 37 commits into from
Dec 27, 2023

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Dec 27, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Sometimes the nuspec file is wrongly encoded in utf-16, the actual encoding is utf-8 but the xml header has enocding="utf-16" key.
xml.Unmarshal doesn't support utf-16 encoding, so we need to convert the header to utf-8.

should fix jfrog/jfrog-cli#840 and jfrog/jfrog-azure-devops-extension#464

sverdlov93 and others added 30 commits August 31, 2023 11:46
@sverdlov93
copy dir
6f4d83a 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
copy dir
99ea1c7 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
copy dir
a2be3c3 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
copy dir
15c2382 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
copy dir
d1ba553 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/build-info-go into cop…
8d2df18 
…y-dir
@sverdlov93
copy dir
43f807c 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/build-info-go into cop…
6588932 
…y-dir
@sverdlov93
fix build script
71df92d 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 @yahavi
Update release/pipelines.yml
417516b 
Co-authored-by: Yahav Itzhak <[email protected]>
@sverdlov93
fix build script
d37e048 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Merge branch 'fix-script' of https://github.com/jfrog/build-info-go i…
014b05b 
…nto copy-dir
@sverdlov93
fix build script
d15dfa7 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
fix build script
3f6f620 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
fix build script
4723df3 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
fix build script
b9c2b05 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
fix build script
6e1e42a 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/build-info-go into cop…
1a05c72 
…y-dir
@sverdlov93
fix build script
8ecbe93 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
fix build script
08989d7 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/build-info-go into cop…
46d3a23 
…y-dir
@sverdlov93
fix build script
a6875ca 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 @yahavi
Update utils/fileutils.go
cf1f3c5 
Co-authored-by: Yahav Itzhak <[email protected]>
@sverdlov93
fix build script
b280efb 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Merge branch 'fix-scripts' of https://github.com/sverdlov93/build-inf…
8685f45 
…o-go into copy-dir
@sverdlov93
fix build script
c94d472 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/build-info-go into cop…
c98060b 
…y-dir
@sverdlov93
fix build script
74d3cd1 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
Merge branch 'dev' into fix-scripts
59bf15d
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/build-info-go into cop…
efc1cb3 
…y-dir
@sverdlov93 sverdlov93 added the bug Something isn't working label Dec 27, 2023
@sverdlov93
fix latest build
5acf77b 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
fix latest build
c3e3e94 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93
fix latest build
ba9935c 
Signed-off-by: Michael Sverdlov <[email protected]>
This was referenced Dec 27, 2023
Closed
Closed
@sverdlov93
fix latest build
5e7fd1c 
Signed-off-by: Michael Sverdlov <[email protected]>
yahavi
yahavi approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sverdlov93 sverdlov93 merged commit a368397 into jfrog:dev Dec 27, 2023
13 of 14 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @yahavi