Sort requires #290
Sort requires #290
Conversation
- Sort `require`s.
- Move type imports above real imports.
- Switch to `@import` for imports needing `resolution-mode`.
- Enable `noUnusedLocals`.
- Move exports to the bottom of files.
- Switch an inline type import to an import declaration.
- Use `... = require('...').default` over `{default: ...} = require('...')`.
- Refactored `spinner.js` exports to be typesafe.
- Fix a type error in `extra-files.js`. Less dependency injection 🙁
|
@jfmengels, pinging b/c this is conflict prone, so the rest of my PRs are blocked on this. |
|
There are a few good things mixed in with this (and I don't want to block your other work that may depend on this), so I've merged it, but this is also not super necessary either. In the sense that if you would have asked me whether we should do something about import sorting, I would likely have told you no. Plus, it was kind of sorted to my own heuristic, now it's sorted to a heuristic I don't know. No worries, but I think there are more interesting things to be worked on in the future 🤷♂️ |
Fair enough.
It looked alphabetical to me, so I thought I'd messed it up.
Agreed. |
Extracted from #253.
No, there's not an eslint rule to enforce this, sadly. I spent a few hours some night in late August when I was procrastinating and didn't want to get my homework done 😉