Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for eslint-plugin-prettier #26

Merged
merged 1 commit into from
Jan 7, 2018
Merged

Add support for eslint-plugin-prettier #26

merged 1 commit into from
Jan 7, 2018

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Sep 13, 2017

No description provided.

@Arcanemagus
Copy link
Collaborator

Does this actually make sense? The link has no dynamic capabilities, and where it is linking to only tells the user how to configure the plugin. Does this plugin even report messages?

@Arcanemagus
Copy link
Collaborator

Ping @SimenB.

@SimenB
Copy link
Contributor Author

SimenB commented Jan 7, 2018

Does this actually make sense?

I'd like to think so 🙂

The link has no dynamic capabilities, and where it is linking to only tells the user how to configure the plugin.

Isn't that that point? At least the second part. There is only a single rule in the plugin, so having it be "dynamic" (if I understand the usage correctly) isn't needed.

Does this plugin even report messages?

It does report messages (see e.g. https://github.com/zertosh/eslint-plugin-prettify/blob/2fb5dfbb52a2577180bf8fcccb83b3fa7aa4d69c/README.md#sample which was ported in prettier/eslint-plugin-prettier#21)

@Arcanemagus
Copy link
Collaborator

Sorry, I think when originally looking at this I glossed over the Sample section thinking it was a sample configuration or something? In either case since this only has the one rule this should work, thanks!

Also note that ESLint officially supports a rule.meta.docs.url property as of v4.15.0 allowing rules to specify where their documentation exists for anything consuming the rule. I'll be updating the contributing.md file shortly here to reflect that 😉.

@Arcanemagus Arcanemagus merged commit 9e2b8a9 into jfmengels:master Jan 7, 2018
@SimenB SimenB deleted the patch-1 branch January 7, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants