-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support eslint-plugin-no-unsanitized #16
Conversation
plugins.json
Outdated
@@ -20,6 +20,7 @@ | |||
"mongodb": "https://github.com/nfroidure/eslint-plugin-mongodb#RULENAME", | |||
"mozilla": "https://gecko.readthedocs.io/en/latest/tools/lint/linters/eslint-plugin-mozilla.html#RULENAME", | |||
"netguru-ember": "https://github.com/netguru/eslint-plugin-netguru-ember/blob/master/docs/RULES.md#RULENAME", | |||
"no-unsanitized": "https://github.com/mozilla/eslint-plugin-no-unsanitized/blob/master/docs/rules/no-unsanitized.md", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want .../docs/rules/RULENAME.md
, so it will automatically work if you add new rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally it looks like you need to split your documentation up a bit, as your rules are method
and property
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This work has now merged in: mozilla/eslint-plugin-no-unsanitized#65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great news @jonathanKingston! Now this PR just needs to be updated as @j-f1 stated so the link will be automatically filled in 😉.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Done 👍
Should be all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Published in v1.0.14. 🎉 |
No description provided.