fix log params (hyperledger#6254)

Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: jflo <[email protected]>
jflo · Dec 12, 2023 · 3ee481b · 3ee481b
1 parent ef2db43
commit 3ee481b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthProtocolManager.java b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthProtocolManager.java
@@ -456,7 +456,11 @@ private void handleStatusMessage(final EthPeer peer, final Message message) {
             message.getConnection());
       }
     } catch (final RLPException e) {
-      LOG.debug("Unable to parse status message from peer {}.", peer, e);
+      LOG.atDebug()
+          .setMessage("Unable to parse status message from peer {}... {}")
+          .addArgument(peer::getShortNodeId)
+          .addArgument(e)
+          .log();
       // Parsing errors can happen when clients broadcast network ids outside the int range,
       // So just disconnect with "subprotocol" error rather than "breach of protocol".
       peer.disconnect(DisconnectReason.SUBPROTOCOL_TRIGGERED);

diff --git a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/ChainHeadTracker.java b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/ChainHeadTracker.java
@@ -95,7 +95,11 @@ public void onPeerConnected(final EthPeer peer) {
                     .addArgument(peer::getShortNodeId)
                     .log();
               } else {
-                LOG.debug("Failed to retrieve chain head info. Disconnecting {}", peer, error);
+                LOG.atDebug()
+                    .setMessage("Failed to retrieve chain head info. Disconnecting {}... {}")
+                    .addArgument(peer::getShortNodeId)
+                    .addArgument(error)
+                    .log();
                 peer.disconnect(DisconnectReason.USELESS_PEER);
               }
             });