Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven testsuite doesn't pass on non-US environement #764

Closed
regisd opened this issue May 12, 2020 · 2 comments · Fixed by #798
Closed

Maven testsuite doesn't pass on non-US environement #764

regisd opened this issue May 12, 2020 · 2 comments · Fixed by #798
Assignees
Labels
testing Adding tests or test infrastructure.
Milestone

Comments

@regisd
Copy link
Member

regisd commented May 12, 2020

Steps

  1. cd testsuite/testcases
  2. ../../mvnw test -Dtestcases=java

Expected:
test passes

Actual:

Test failed, unexpected jflex output: Difference in line 7
expected :[Constructing NFA : 1,010 states in NFA]
but got  :[Constructing NFA : 1.010 states in NFA]
JFlex output: Reading "src/test/cases/java/java.flex"

Warning in file "src/test/cases/java/java.flex" (line 340):
".|\n" does not match all characters, because "." excludes all Unicode newline chars - use "[^]" instead
.|\n                             { throw new RuntimeException("Illegal character \""+yytext()+
^
Constructing NFA : 1.010 states in NFA
Converting NFA to DFA :
................................................................................................................................................................................................................................................................................................................................................................................................................................................................
454 states before minimization, 426 states in minimized DFA
Writing code to "src/test/cases/java/Java.java"

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.207 s
[INFO] Finished at: 2020-05-12T21:57:52+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal de.jflex:jflex-testsuite-maven-plugin:1.9.0-SNAPSHOT:run-test-suite (default) on project jflex-testsuite-testcases: Failed to execute test suite: Test [src/test/cases/java/java.test] failed: Unexpected jflex output:
[ERROR] Difference in line 7
[ERROR] expected :[Constructing NFA : 1,010 states in NFA]
[ERROR] but got  :[Constructing NFA : 1.010 states in NFA]
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal de.jflex:jflex-testsuite-maven-plugin:1.9.0-SNAPSHOT:run-test-suite (default) on project jflex-testsuite-testcases: Failed to execute test suite: Test [src/test/cases/java/java.test] failed
@regisd regisd added the testing Adding tests or test infrastructure. label May 12, 2020
@regisd regisd added this to the 1.9.0 milestone May 12, 2020
@regisd regisd self-assigned this May 12, 2020
@regisd
Copy link
Member Author

regisd commented May 12, 2020

Observe the diff

Constructing NFA : 1,010 states in NFA
vs
Constructing NFA : 1.010 states in NFA

Hint if you still don't see it because it took me some time: Number format differs.

regisd added a commit to regisd/jflex that referenced this issue May 12, 2020
@lsf37
Copy link
Member

lsf37 commented May 13, 2020

Wow. That is unexpectedly annoying :-). Thanks for spotting that.

regisd added a commit to regisd/jflex that referenced this issue Dec 17, 2020
lsf37 pushed a commit that referenced this issue Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Adding tests or test infrastructure.
Projects
None yet
2 participants