Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Sprockets 3.0 #217

Closed
wants to merge 3 commits into from

Conversation

alexkravets
Copy link
Contributor

No description provided.

@jfirebaugh
Copy link
Owner

Thanks @alexkravets. Where does this stand with respect to #216 (comment)?

@alexkravets
Copy link
Contributor Author

@jfirebaugh no backward compatibility for sprockets-rails < 3.0. So seems like Rails 4.1 is not an option, as that one has sprockets-rails ~> 2.0. Correct me if I'm wrong.

@jfirebaugh
Copy link
Owner

Ok, I can't accept this PR as-is then. Konacha needs to maintain compatibility with Rails 4.1.

@alexkravets
Copy link
Contributor Author

@jfirebaugh do you want me to bump version?

@jfirebaugh
Copy link
Owner

@alexkravets Which version are you referring to?

@alexkravets
Copy link
Contributor Author

@jfirebaugh we can bump konacha major version, so for Rails 4.1 support you would need to keep the current one locked.

@jfirebaugh
Copy link
Owner

No -- I want to maintain Rails 4.1 and sprockets 2 support:

  • No changes to konacha.gemspec

  • Add Gemfile-rails42-sprockets2 with

      gem "railties", "~> 4.2.0"
      gem "sprockets-rails", "~> 2.0"
    
  • Conditionalize any additions that depend on a sprockets 3 API

@alexkravets
Copy link
Contributor Author

@jfirebaugh we have no interest to do that.

@jfirebaugh
Copy link
Owner

Ok, sorry but I can't accept this PR in that case.

@jfirebaugh jfirebaugh closed this Feb 3, 2016
@alexkravets
Copy link
Contributor Author

No problem.

@rafamanzo
Copy link

@alexkravets I hope you don't mind but I've made a patch that adds the conditionals for sprockets 3 API and undo konacha.gemspec modifications: https://gist.github.com/rafamanzo/4deafb6546ffd350a689

I hope you can apply it, so @jfirebaugh can reopen and accept this. It you are really not interested on it, do you mind if a open a new PR with such changes?

Thanks!

@alexkravets
Copy link
Contributor Author

@rafamanzo new pull request has been created: #219 — with your patch applied, thanks!

@jfirebaugh please take a look, now this should be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants